-
Notifications
You must be signed in to change notification settings - Fork 95
Fix incorrect disconnect status code #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@CodeWithKyrian do you recall why it's 204 - can't find sth in the specs directly? |
|
Yeah, there’s nothing in the MCP spec that requires a specific code here. The only other 2xx mentioned is for notifications (202). We went with 204 because it’s the standard HTTP response for a successful DELETE with no body. I haven’t seen any MCP clients reject it, so it seemed like the most logical choice at the time. |
I tested with MCP Inspector v0.17.2 and it cannot shut down properly. The error is shown in the previously mentioned image. I compared it with Typescript SDK, and they indeed return 200. |
|
Give me a few minutes to verify |
|
Im reading the specification here. I fail to reproduce the errors your screenshot. (I think you are correct, but I fail to verify) Can you please share how you start the inspector and how to reproduce? |
|
|
Could reproduce locally with inspector: and also verify that it works with this branch - thanks @lvluoyue for the patch! |
|
Sorry, my bad. You need to use "proxy", and not "direct" setting. I see both 200 and 202 works and the specification does not cover this. Im happy with this change. |


HTTP status code should return 200
